Argus 9-gate review — #4804

Substance: LGTM. Code is clean, well-scoped, well-tested. No blockers from a review-standards perspective. Highlights:

• 44 tests (16 + 8 + 20) cover the Path 2 defensive surface (pre-F-9 + post-F-9), enum exhaustiveness, exhaustion sub-label, kill-switch overlay, tooltip composition, and schema backwards-compat.
• Bounded ErrorClass enum (ErrorClassSchema) — schema PR enforces drift discipline; no free-form strings reach the pill (F-6 redaction discipline preserved).
• Type-safe — no as any in renderer code; the one cast in schemas.ts is the established transform-then-narrow pattern with explanatory comment.
• All new files ≤200 lines (StallBadge 108, SendContinueButton 70, stallClassLabels 115, schemas +50).
• Renderer-only gating — SendContinueButton checks presence + exhaustion + kill-switch before showing. No bypass of server config.
• Close-format alignment with Athena's PM canonical re-anchoring (issuecomment-4767577518): PR #4803 ✅ merged, F-9 (Hep) pending, this PR is the renderer slice.

Blocker — CI gate (Gate 3 FAIL):

X feat-minor-bump-gate in 3s (ID 82718515444)
  feat: PRs require the approved-minor-bump label before CI can pass.

Per feat(dashboard): conventional commit, the feat-minor-bump-gate is correctly enforcing the per-PR release-authorization policy (MEMORY 2026-06-16: gate (1) — Ema's approved-minor-bump label clears the per-PR check).

Required from @OneStepAt4time (Ema):

1. Apply the approved-minor-bump label to this PR → re-run CI → I squash-merge on green, OR
2. Re-classify the commit (e.g., fix(dashboard): if it's positioning as a bugfix rather than a feature) — the gate only fires on feat PRs, OR
3. Confirm hold pending F-9 so this PR batches with the typed-payload wire work before release authorization.

Substance review is complete. Standing by for the gate decision — no further review work needed unless scope changes.

— Argus 👁️ (via aegis-gh-agent[bot])

👁️ Code review: substance LGTM, awaiting gate label.

9-gate audit

Substance highlights

Architecture is sound:

• Path 2 defensive — works on free-form emits (pre-F-9) and typed emits (post-F-9). Pre-F-9 state shows generic "Stalled" pill (no info), post-F-9 shows typed labels + sub-label + AC3b button.
• ErrorClass is a bounded enum (6 values) mirrored from server src/stall-events.ts — schema drift cannot grow unchecked; new values require schema PR.
• StallEventPayload Zod schema with all fields .optional() + safe defaults — defensive against partial wire payloads.
• SessionSSEEventDataSchema cast is documented (needed for Zod transform output type narrowing); no other as any in renderer code.
• All new files ≤200 lines (StallBadge 108, stallClassLabels 115, SendContinueButton 70, schemas +59).

AC3b gating logic is correct:

1. typed payload present (otherwise render null — Path 2 default)
2. recovery exhausted (attempt >= max, both > 0)
3. kill-switch NOT engaged

The button stays hidden in all pre-F-9 states — appropriate defensive default.

Tooltip composition honors F-6 redaction discipline — composes metadata only (errorClass label + statusCode for transient_5xx only + ISO timestamp + duration + sub-label), never includes raw detail field from legacy status.stall event. Consistent with PR #4803 server-side redaction.

Outstanding gate (not blocking code review)

feat-minor-bump-gate requires the approved-minor-bump label on this PR. This is the per-PR release-authorization lane (per MEMORY 2026-06-16, owner=Ema).

Once Ema applies the label, the workflow re-evaluates and CI should go green. I will squash-merge via bot API at that point.

Open follow-ups (already noted in PR body, out of scope here)

• F-9 (Hep): wire buildStallEventPayload into 12 emit sites so the typed payload flows in the wire payload. Until F-9 lands, the renderer falls back to generic pill. This PR is renderer-defensive-by-design.
• SSE event handler: add a hook to populate stallMap from status.stall.typed events when F-9 wires them.

Verdict

Code: LGTM. Merge: pending label.

cc @hephaestus — FYI on the F-9 wiring follow-up so the renderer transitions from generic-pill to typed-pill mode once the typed payload flows.
cc @ag-manudis — approved-minor-bump label needed to clear feat-minor-bump-gate.

Request Changes — Issue: StallBadge always renders for healthy sessions

Critical bug: every session detail page will show a red "Stalled" pill

dashboard/src/components/session/SessionHeader.tsx:176 wires the new pill unconditionally:

const stallPayload = useStore((s) => s.stallMap[session.id]);
// ...
<StallBadge payload={stallPayload ?? {}} />

For any session with no active stall event, stallPayload is undefined → StallBadge receives {} → returns a span with:

• label "Stalled" (generic fallback)
• color red (because errorClass !== 'transient_5xx')
• aria-label="Session stall: Stalled"
• title="Stalled" (the tooltip)

Result: every session header on every session detail page load now shows a red "Stalled" pill, including idle/healthy sessions. Screen readers announce "Session stall: Stalled" for every session. This is a UX regression visible on every page in the app.

The unit tests pass because they only exercise the component in isolation. There's no integration test for SessionHeader that would catch this.

Fix (one of):

// Option A — gate at the callsite
{stallPayload && <StallBadge payload={stallPayload} />}

// Option B — gate inside the component (mirrors SendContinueButton's pattern at L36)
if (!payload || Object.keys(payload).length === 0) return null;

I prefer A — keeps StallBadge as a pure presentational component for the "there IS a stall" case, and matches how SendContinueButton is already gated.

Quality follow-up (not blocking)

dashboard/src/api/schemas.ts:384 adds 'status.stall.typed' to SSEEventTypes, but the existing SessionSSEEvent discriminated union (backend contract) doesn't include that variant yet — that's why the explicit annotation was downgraded to as unknown as z.ZodType<SessionSSEEvent>. The cast works at runtime but hides a type mismatch. Please add an inline // TODO(#4802 F-9): remove cast when SessionSSEEvent accepts 'status.stall.typed' so the removal is findable.

Merge gate

feat-minor-bump-gate is FAILING on this PR (per-PR gate, requires approved-minor-bump label applied by Ema per MEMORY 2026-06-16). Code review can complete on technical merit; the gate is the per-PR release authorization which is Ema's call.

Strengths (worth calling out)

• Path 2 defensive design is sound — component handles missing fields with safe defaults
• Bounded ErrorClass enum + Zod mirror of server schema prevents schema drift / prompt injection
• AC3b gating mirrors existing useSessionIntervention patterns
• formatStallTooltip correctly excludes the detail field per F-6 redaction discipline
• 44 new tests cover happy path + boundaries + path-2 defaults
• File-size discipline: largest new file is 127 lines (utility test), well under the 500-line gate

Resubmit after the SessionHeader gate fix and the inline TODO on the cast, and I'll re-review.

👁️ 9-gate review — APPROVED (substance LGTM, merge gate still blocked)

Fix verification (commit d029526)

Review #3 critical bug properly fixed with defense in depth:

1. Component guard (StallBadge.tsx): early return null when payload has no useful stall data — no errorClass, no recoveryDisabled, no recovery counter. Clean, well-commented.
2. Callsite guard (SessionHeader.tsx:176): {stallPayload && <StallBadge payload={stallPayload} />} — Option A (my preferred pattern) applied. No more ?? {} fallback hiding the bug.
3. Test updates — StallBadge.test.tsx "empty payload" case flipped from "renders Stalled" → "returns null". New StallBadge.guard.test.tsx adds 6 guard tests (empty / undefined-only / zero-counters / errorClass-present / kill-switch / counter-nonzero). Coverage is solid.
4. TODO comment on the as unknown as cast in schemas.ts — explains F-9 follow-up rationale. Acceptable.

9-gate audit

Substance verdict: APPROVED. Code is clean, well-scoped, defense in depth applied correctly.

🚧 Merge blocker: feat-minor-bump-gate FAILURE

Per-PR release authorization gate requires the approved-minor-bump label (Ema applies manually per MEMORY 2026-06-16 lane convention). Gate (1) is not cleared for this PR.

Action needed: Ema (or Boss) to apply the approved-minor-bump label to PR #4804. Once applied, the gate re-evaluates and the merge proceeds.

Until then, I am NOT squashing — gate 3 is FAILURE and SOUL.md is non-negotiable on this.

— Argus 👁️